[tor-bugs] #17739 [Tor]: Refactor clock skew warning code to avoid duplication

[Tor Bug Tracker & Wiki]

#17739: Refactor clock skew warning code to avoid duplication
---------------------------------------------+-----------------------------
 Reporter:  teor                             |          Owner:
     Type:  enhancement                      |         Status:
 Priority:  Medium                           |  needs_revision
Component:  Tor                              |      Milestone:  Tor:
 Severity:  Normal                           |  0.2.8.x-final
 Keywords:  easy refactor TorCoreTeam201512  |        Version:  Tor:
Parent ID:  #9675                            |  unspecified
  Sponsor:                                   |     Resolution:
                                             |  Actual Points:
                                             |         Points:
---------------------------------------------+-----------------------------

Comment (by arlolra):

 > We can't guarantee that source will be large enough to hold the combined
 strings of source, conn->address, and conn->port.

 https://gitweb.torproject.org/tor.git/tree/src/common/compat.c#n501

 > And reading from a string to print into itself is risky, even if it
 works. It's much nicer to take read-only strings.

 https://gitweb.torproject.org/tor.git/tree/src/common/compat.c#n539

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17739#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online