[tor-bugs] #17795 [Tor]: Evaluate usage of digests_t, crypto_digest_all, etc.

[Tor Bug Tracker & Wiki]

#17795: Evaluate usage of digests_t, crypto_digest_all, etc.
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:
     Severity:  Normal  |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------
 When we added sha256, we added a type that would contain a sha1 digest and
 a sha256 digest, and some convenience code to compute both.  That's
 reasonable.

 But now we have three digest types supported.  Soon (with #17783) we might
 have more.

 We should make sure that we don't actually use digests_t and
 crypto_digests_all any time we are in a critical path, unless we really
 want to compute '''all''' the digests.  We might want to consider other
 APIs here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17795>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online