[tor-bugs] #17739 [Tor]: Refactor clock skew warning code to avoid duplication

[Tor Bug Tracker & Wiki]

#17739: Refactor clock skew warning code to avoid duplication
---------------------------+------------------------------------
 Reporter:  teor           |          Owner:
     Type:  enhancement    |         Status:  needs_revision
 Priority:  Medium         |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor            |        Version:  Tor: 0.2.7
 Severity:  Normal         |     Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID:  #9675          |         Points:
  Sponsor:                 |
---------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 +1 for dgoulet's comments: let's describe the parameters in a comment
 (other functions do this), and make the pointers const.

 ''Refactor or_state_load''

 or_state_load also issues a clock skew warning when the state file
 contains a last written date in the future.

 Can you update the patch so it calls clock_skew_warning from
 or_state_load?

 ''Note that servers could be wrong or lying about the time''

 In #17716, nickm wanted the clock skew message to mention that remote
 servers could be sending the wrong time. I'll remove it from that branch,
 and we can fix it here.

 Please add:
 "or the remote server is sending us the wrong time"
 when there is a remote server. (There won't be a remote server if we're
 reading the time from the state file.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17739#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online