[tor-bugs] #14828 [Tor]: Multiple hidden services can share a pk_digest/service_id.

[Tor Bug Tracker & Wiki]

#14828: Multiple hidden services can share a pk_digest/service_id.
-------------------------+------------------------------------
 Reporter:  yawning      |          Owner:
     Type:  defect       |         Status:  needs_revision
 Priority:  Very Low     |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:  Tor: 0.2.7
 Severity:  Minor        |     Resolution:
 Keywords:  easy tor-hs  |  Actual Points:
Parent ID:               |         Points:  small
  Sponsor:  SponsorR     |
-------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 This patch moves the check to `rend_service_load_keys()` which makes sense
 but when adding an ephemeral onion we do not call it ending up with a case
 where we could have a collision.

 {{{
   /* Enforcing pk/id uniqueness should be done by
 rend_service_load_keys(), but
    * it's not, see #14828. */
 }}}

 I think what we need here is a function that checks for the service key if
 it already exists and then called before adding the ephemeral service and
 also at load keys.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14828#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online