[tor-bugs] #17772 [Tor]: We don't consider the Guard flag when picking a directory guard

[Tor Bug Tracker & Wiki]

#17772: We don't consider the Guard flag when picking a directory guard
--------------------+------------------------------------
 Reporter:  arma    |          Owner:
     Type:  defect  |         Status:  needs_review
 Priority:  Medium  |      Milestone:  Tor: 0.2.7.x-final
Component:  Tor     |        Version:
 Severity:  Major   |     Resolution:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
  Sponsor:          |
--------------------+------------------------------------

Comment (by arma):

 Patch looks good to me.

 Here's a go at a changes entry:
 {{{
   o Major bugfixes (guard selection):
     - Actually look at the Guard flag when selecting a new directory
       guard. When we implemented the directory guard design, we
       accidentally started treating all relays as if they have the Guard
       flag during guard selection, leading to weaker anonymity and worse
       performance. Fixes bug 17222; bugfix on 0.2.4.8-alpha. Discovered
       by Mohsen Imani.
 }}}

 I think we should backport it starting from 0.2.4.x, and then only put out
 new stable releases in cases where we know that a package maintainer
 actually wants to move to it (e.g. hopefully Tor 0.2.6, definitely 0.2.7,
 but probably not 0.2.4 or 0.2.5).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17772#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online