[tor-bugs] #17753 [Tor]: Use internal reputation variables to verify memory allocation

[Tor Bug Tracker & Wiki]

#17753: Use internal reputation variables to verify memory allocation
-------------------------+------------------------------------
 Reporter:  cypherpunks  |          Owner:
     Type:  defect       |         Status:  needs_revision
 Priority:  Low          |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:  Tor: unspecified
 Severity:  Minor        |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * milestone:   => Tor: 0.2.8.x-final


Comment:

 This patch looks good - thanks for making sure we don't leak this memory.

 Can you explain the removal of the cast from the line:
 `lhist = (link_history_t*) digestmap_get(orhist->link_history_map, to_id);
 `

 Did you mean to include it in the patch?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17753#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online