[tor-bugs] #17751 [Tor]: Use router_get_my_routerinfo() rather than desc_routerinfo

[Tor Bug Tracker & Wiki]

#17751: Use router_get_my_routerinfo() rather than desc_routerinfo
------------------------+--------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:
     Severity:  Minor   |   Keywords:  easy
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------
 The following functions use desc_routerinfo where they could use
 router_get_my_routerinfo():
 * check_descriptor_ipaddress_changed
 * router_compare_to_my_exit_policy
 * router_my_exit_policy_is_reject_star
 * router_get_my_descriptor
 * check_descriptor_bandwidth_changed

 This could cause issues if desc_routerinfo needs to be rebuilt, because
 some of these functions don't call router_get_my_routerinfo() first.

 Others have comments about desc_routerinfo that might need to be updated:
 * dirserv_get_routerdescs
 * router_compare_to_my_exit_policy
   * Also change "IPv6 and IPv6 entries" to "IPv4 and IPv6 entries"

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17751>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online