[tor-bugs] #17565 [Tor Browser]: Banner on about:tor page

[Tor Bug Tracker & Wiki]

#17565: Banner on about:tor page
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:
     Type:  defect                               |  arthuredelstein
 Priority:  High                                 |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  funding, crowdfunding, donations,    |        Version:
  TorBrowserTeam201512R                          |     Resolution:
Parent ID:  #17534                               |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:19 mcs] (comment 19):
 > Replying to [comment:18 teor]:
 > > I like how the banners look, but I find it hard to read the green-on-
 yellow "Please support Tor!"
 > >
 > > Does anyone else have this issue, or is it just my eyesight / monitor?
 >
 > Kathy and I can both read the text without any trouble. We do think it
 might look better with more yellow background above and on the left and
 right sides.  Also, Kathy says that the yellow does not match the overall
 banner color scheme (but she admits that she is not a color expert).

 Thank you for the quick reviews, teor, Kathy and Mark! I padded the yellow
 background some more. The yellow color violates my sensibilities as well,
 but we are aiming for something that draws the user's attention. Yellow-
 highlighted text has worked for another famous organization with funding
 campaign banners, so we're giving it a try.

 > There is one more small point about the "Please support Tor!" text that
 Arthur should address: the color of the text changes when you hover over
 any part of the banner (due to an existing 'a:hover' CSS rule).

 Good point -- fixed. The text now stays dark green, which I hope will be
 easier to read against the yellow background.

 Replying to [comment:20 mcs] (comment 20):
 > Kathy and I reviewed these changes. We have a bunch of minor code
 comments:
 > - The wrong indent is used in a couple of places: please fix the line
 where setupDonationBanner() is called and the #donation-banner-text CSS
 rules.
 > - The line that has 'document.getElementById("donation-banner-
 image").src =' is very long. Please break it up.
 > - Since you are doing a Date object inequality comparison, you do not
 need to use getTime().
 > - We would feel better if the call to gStringBundle.GetStringFromName()
 was wrapped in a try/catch (it would be bad if a bug in the banner
 translations caused the entire about:tor page to fail).
 > - Please move the three top-level-scope lines that set gStringBundle
 above onLoad() so they are easier to notice.
 > - For consistency, we suggest renaming alternates to gBannerAlternates,
 suffixes to gBannerSuffixes, and populate() to populateBannerText().
 > - For consistency with the other Torbutton prefs, the new pref should be
 named something like extensions.torbutton.donation_banner.shown_count.

 All fixed -- thanks.

 Replying to [comment:21 mcs] (comment 21):
 > One thing I forgot to mention: the Donate button's "move down" behavior
 seems unusual to me, at least on Mac OS where most buttons just stay put
 when you click on them. I think not moving is part of the flat design
 trend, but I am not a design expert.

 Good point. I have removed that behavior.

 Here is the revised patch:
 https://github.com/arthuredelstein/torbutton/commit/17565+5

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17565#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online