[tor-bugs] #17565 [Tor Browser]: Banner on about:tor page

[Tor Bug Tracker & Wiki]

#17565: Banner on about:tor page
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:
     Type:  defect                               |  arthuredelstein
 Priority:  High                                 |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  funding, crowdfunding, donations,    |        Version:
  TorBrowserTeam201512R                          |     Resolution:
Parent ID:  #17534                               |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Kathy and I reviewed these changes. We have a bunch of minor code
 comments:
 - The wrong indent is used in a couple of places: please fix the line
 where setupDonationBanner() is called and the #donation-banner-text CSS
 rules.
 - The line that has 'document.getElementById("donation-banner-image").src
 =' is very long. Please break it up.
 - Since you are doing a Date object inequality comparison, you do not need
 to use getTime().
 - We would feel better if the call to gStringBundle.GetStringFromName()
 was wrapped in a try/catch (it would be bad if a bug in the banner
 translations caused the entire about:tor page to fail).
 - Please move the three top-level-scope lines that set gStringBundle above
 onLoad() so they are easier to notice.
 - For consistency, we suggest renaming alternates to gBannerAlternates,
 suffixes to gBannerSuffixes, and populate() to populateBannerText().
 - For consistency with the other Torbutton prefs, the new pref should be
 named something like extensions.torbutton.donation_banner.shown_count.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17565#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online