[tor-bugs] #17565 [Tor Browser]: Banner on about:tor page

[Tor Bug Tracker & Wiki]

#17565: Banner on about:tor page
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:
     Type:  defect                               |  arthuredelstein
 Priority:  High                                 |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  funding, crowdfunding, donations,    |        Version:
  TorBrowserTeam201512R                          |     Resolution:
Parent ID:  #17534                               |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:14 mcs]:
 > A few quick comments:
 > - To allow localization, the text needs to be moved to the aboutTor.dtd
 file.
 > - Use of "text-align: left" may cause trouble if we translate to an RTL
 language. Remove it if it is not needed, and consider testing with
 placeholder Farsi or Arabic text to find potential problems now.
 > - There is a lot of inline CSS. Move some of it to aboutTor.css if you
 have time (that will make the HTML easier to read and make everything more
 maintainable).
 > - If possible, keep line lengths under or near 80. Moving the CSS out of
 the HTML file should make that possible.

 Thanks for these useful suggestions. I have adopted them in the following
 revised patch:
 https://github.com/arthuredelstein/torbutton/commit/17565+4

 This version uses Leiah's new banner design. As currently implemented, the
 banner will be visible in English only, until January 25 or until the
 banner has been displayed 10 times (whichever happens first). There are
 three champions, one of which is shown randomly with each new Tor Browser
 window.

 *If we manage to get the strings translated in time then I will enable the
 available languages and review the layout for each language.)

 Here are two screenshots:

 [[Image(Screen Shot 2015-12-03 at 12.01.01 AM.png)]]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17565#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online