[tor-bugs] #17065 [Tor]: Tor should leave its own fingerprint out of its family line

[Tor Bug Tracker & Wiki]

#17065: Tor should leave its own fingerprint out of its family line
------------------------------+------------------------------
 Reporter:  teor              |          Owner:
     Type:  enhancement       |         Status:  new
 Priority:  Low               |      Milestone:  Tor: 0.2.???
Component:  Tor               |        Version:  Tor: 0.2.7
 Severity:  Normal            |     Resolution:
 Keywords:  easy, regression  |  Actual Points:
Parent ID:                    |         Points:
  Sponsor:                    |
------------------------------+------------------------------
Changes (by teor):

 * keywords:  easy => easy, regression


Comment:

 Replying to [comment:6 feverDream]:
 > I would be happy to work on this. After asking around on the tor-dev
 channel, user "qwerty1" suggested enabling debug logs and performing git-
 bisect to find why its not working on 0.2.6.9.
 >
 > I will try to do that in the next couple of days. Any pointers?

 This is a regression: the feature worked in 0.2.6.9, it doesn't work on
 0.2.8.0-alpha-dev.

 It will help to write a unit test for router_build_fresh_descriptor, and
 then bisect based on that.

 We've checked the code, and:
 * `if (!strcasecmp(name, options->Nickname))` correctly removes the
 nickname of this relay from MyFamily
 * `} else if (router_digest_is_me(member->identity)) {` doesn't remove the
 fingerprint of this relay from MyFamily (when a relay is launched using
 chutney, and I looked at its first descriptor)
   * `member = node_get_by_nickname(name, 1);` could be failing to find our
 relay, because it's not in the consensus yet. You could try checking
 `router_digest_is_me(nickname)` after `if (!strcasecmp(name,
 options->Nickname))`, and skipping the fingerprint as well.
     * (We can't fix `node_get_by_nickname` in this case, because we can't
 return a node_t for ourselves when we're not in the consensus.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17065#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online