[tor-bugs] #16924 [Tor]: Properly free channel during channel_free_list

[Tor Bug Tracker & Wiki]

#16924: Properly free channel during channel_free_list
---------------------------+--------------------------------
     Reporter:  Sebastian  |      Owner:
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor        |    Version:
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+--------------------------------
Changes (by nickm):

 * milestone:  Tor: 0.2.7.x-final => Tor: 0.2.8.x-final


Comment:

 It's okay to do it the way that channel_free_list() does it now, so long
 as the list isn't used again.  So that's fine.  The issue here is that the
 function doesn't document that it invalidates the lists.  I'd prefer a
 documentation fix for this, and possibly doing a smartlist_clear() at the
 end of the functions.  Also see channel_listener_free_list().

 Please let me know if I messed up the analysis here!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16924#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online