[tor-bugs] #16894 [Tor]: Check all logging output is appropriately escaped / escaped_safe_str_client

[Tor Bug Tracker & Wiki]

#16894: Check all logging output is appropriately escaped / escaped_safe_str_client
------------------------------------------------+--------------------------
 Reporter:  teor                                |          Owner:
     Type:  task                                |         Status:  new
 Priority:  normal                              |      Milestone:  Tor:
Component:  Tor                                 |  0.2.7.x-final
 Keywords:  TorCoreTeam201509 security logging  |        Version:  Tor:
Parent ID:                                      |  unspecified
                                                |  Actual Points:
                                                |         Points:
------------------------------------------------+--------------------------
 Security bugs like #16891 show up every so often, where sensitive input is
 logged, rather than being obscured. Similarly, client input is sometimes
 logged unsanitised (I fixed one of these in the directory request logging
 code about 9-12 months ago.)

 It would be great if someone could review all the strings that are logged
 by Tor, and categorise them into:
 * static or calculated internally: trusted, log as-is
 * externally provided: unsanitised, use escaped()
 * sensitive client information: use escaped_safe_str_client()

 Do we want this in 0.2.7, or should we leave it until 0.2.8?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16894>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online