[tor-bugs] #16847 [Tor Browser]: torbrowser-install-5.0_en-US.exe does not start on Vista 32-bit
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat Aug 22 05:07:26 UTC 2015
#16847: torbrowser-install-5.0_en-US.exe does not start on Vista 32-bit
-----------------------------+-------------------------------
Reporter: ljacob | Owner: tbb-team
Type: defect | Status: needs_information
Priority: major | Milestone:
Component: Tor Browser | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-----------------------------+-------------------------------
Comment (by cypherpunks):
> Also, I'm not the only one with this issue (torforum
viewtopic.php?f=2&t=65725)
Link is about torforum.org/viewtopic.php?f=2&t=65725
>Has the installer torbrowser uses changed in any way (version, default
settings etc) since 3.6.4?
Difference inbetween [https://github.com/moba/tbb-windows-installer NSIS
script for Tor Browser Bundle Windows installer] v0.1 (used by 3.6.4) and
v0.3 (used by 4.5 and 5.0):
{{{
--- torbrowser.nsi.v0.1 2013-06-14 21:50:20.000000000 +0000
+++ torbrowser.nsi.v0.3 2015-03-18 04:56:58.000000000 +0000
@@ -13,7 +13,7 @@
; location of Tor Browser bundle to put into installer
!define TBBSOURCE ".\Tor Browser\"
- Name "Tor Browser Bundle"
+ Name "Tor Browser"
OutFile "torbrowser-install.exe"
;Default installation folder
@@ -35,7 +35,11 @@
;--------------------------------
;Modern UI settings
!define MUI_FINISHPAGE_NOREBOOTSUPPORT ; we don't require a reboot
- !define MUI_FINISHPAGE_RUN "$INSTDIR\Start Tor
Browser.exe"
+ !define MUI_FINISHPAGE_RUN
+ !define MUI_FINISHPAGE_RUN_FUNCTION "StartTorBrowser"
+ !define MUI_FINISHPAGE_SHOWREADME ; misuse for option to create
shortcut; less ugly than MUI_PAGE_COMPONENTS
+ !define MUI_FINISHPAGE_SHOWREADME_TEXT "&Add Start Menu && Desktop
shortcuts"
+ !define MUI_FINISHPAGE_SHOWREADME_FUNCTION "CreateShortCuts"
;--------------------------------
;Pages
@@ -125,9 +129,17 @@
SetOutPath "$INSTDIR"
File /r "${TBBSOURCE}\*.*"
-
+ SetOutPath "$INSTDIR\Browser"
+ CreateShortCut "$INSTDIR\Start Tor Browser.lnk"
"$INSTDIR\Browser\firefox.exe"
+
SectionEnd
+Function CreateShortcuts
+
+ CreateShortCut "$SMPROGRAMS\Start Tor Browser.lnk"
"$INSTDIR\Browser\firefox.exe"
+ CreateShortCut "$DESKTOP\Start Tor Browser.lnk"
"$INSTDIR\Browser\firefox.exe"
+
+FunctionEnd
;--------------------------------
;Installer Functions
@@ -147,5 +159,9 @@
NoAbort:
${EndIf}
FunctionEnd
-
+
+
+Function StartTorBrowser
+ExecShell "open" "$INSTDIR/Start Tor Browser.lnk"
+FunctionEnd
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16847#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list