[tor-bugs] #16679 [Tor]: Ed25519 --keygen won't work

[Tor Bug Tracker & Wiki]

#16679: Ed25519 --keygen won't work
-------------------------+-------------------------------------------------
     Reporter:  s7r      |      Owner:  nickm
         Type:  defect   |     Status:  needs_revision
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7.2-alpha
   Resolution:           |   Keywords:  ed25519, identity, keys,
Actual Points:           |  TorCoreTeam201508
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 844ba78660819effabc28c21010d71f1c0114855
  * in src/or/or.h (duper bikeshed color)
   * The new enum in `or_options_t` would be great to have each value on
 different line and assigned with its value (= 1, = 2,).
   * Extra newline right after `TestingAuthKeySlop`
   * `puts("E");` is removed in c0e89863ca354dac163c87d61a213466eff2c96f so
 good!
   * All fixup and the rest lgtm;

 71257e22392eedbe10aca4345b22e8c5cab1a795
  * In src/or/routerkeys.c
   * Missing dot at the end of both sentences of the new `log_notice`
 introduced.

 The rest lgtm; However, documentation is missing for some key things like
 the new arguments added to tor (`--no-passphrase` and `--passphrase-fd`,
 both in or.h and man page).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16679#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online