[tor-bugs] #16812 [Tor Browser]: Tor Browser leaks updater temp files on OS X

[Tor Bug Tracker & Wiki]

#16812: Tor Browser leaks updater temp files on OS X
-----------------------------+-------------------------------
     Reporter:  teor         |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_information
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------

Comment (by teor):

 Replying to [comment:1 mcs]:
 > Thank you for reporting this problem.  In theory, we modified the
 Firefox updater code to avoid placing things in temporary directories, but
 we must have missed something.  Can you provide steps to reproduce the
 problem?
 Unfortunately, I can't reproduce it.

 >Is the temporary directory the one that $TMPDIR points to or is it
 another location?
 I don't know, I only found the files after the OS moved them to the Trash
 after a restart. For general info on "Recovered Files" on OS X, see
 https://support.apple.com/kb/PH18793?locale=en_US

 As a guess, the files may have been in /tmp, $TMPDIR, or under the
 /private/var/folders hierarchy.

 > The only reference to "bgupdate" that I can find in the code is in
 toolkit/xre/nsUpdateDriver.cpp, and in Tor Browser the code in that file
 has been modified to place the UpdateInfo directory under .../Tor
 Browser.app/TorBrowser/UpdateInfo/
 I really can't say, but the only way they could have been moved to the
 Trash by the OS was if they were in a temporary directory (not the app
 directory).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16812#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online