[tor-bugs] #16823 [Tor]: potential double-free in command_process_create_cell()

[Tor Bug Tracker & Wiki]

#16823: potential double-free in command_process_create_cell()
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  blocker  |  Milestone:
    Component:  Tor      |    Version:  Tor: 0.2.4.10-alpha
   Resolution:           |   Keywords:  tor-relay, tor-guard, security,
Actual Points:           |  024-backport, 025-backport, 026-backport
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by nickm):

 PREDICT_LIKELY()  expands to:
 {{{
 /** Macro: Evaluates to <b>exp</b> and hints the compiler that the value
  * of <b>exp</b> will probably be true.
  *
  * In other words, "if (PREDICT_LIKELY(foo))" is the same as "if (foo)",
  * except that it tells the compiler that the branch will be taken most of
 the
  * time.  This can generate slightly better code with some CPUs.
  */
 #define PREDICT_LIKELY(exp) __builtin_expect(!!(exp), 1)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16823#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online