[tor-bugs] #16741 [Tor]: recv_ni() and friends don't ask about errno the Windows way?

[Tor Bug Tracker & Wiki]

#16741: recv_ni() and friends don't ask about errno the Windows way?
------------------------+--------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by someone_else):

 Replying to [ticket:16741 arma]:
 > A) Looking through src/common/compat_threads.c I see that sock_drain()
 (which is what drain_fd uses if we decided socketpair was the best way to
 make a pipe) calls recv_ni() which flat-out just looks at errno

 Windows socket functions don't set errno. So this is a bug.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16741#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online