[tor-bugs] #15816 [Tor]: HS Descriptor Fetch retry behavior is broken.

[Tor Bug Tracker & Wiki]

#15816: HS Descriptor Fetch retry behavior is broken.
-------------------------+--------------------------------
     Reporter:  yawning  |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7
   Resolution:           |   Keywords:  SponsorR tor-hs
Actual Points:           |  Parent ID:
       Points:  medium   |
-------------------------+--------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Big thanks. Here are the fixes: `bug15816_027_04`.

 > Does it matter that when we updating descriptor IDs in
 fetch_v2_desc_by_addr, we don't touch IDs for all replicas?

 I'm not sure to understand but the loop here makes sure all replicas are
 updated if needed.

 > Does that mean the descriptor id will be ignored, or that it will be
 used after the onion id, or do we not know? If there isn't any logical
 behavior when both are non-NULL, maybe it shouldn't accept both.

 Yes, I made a slight change to make it more obvious. There are no use
 cases right now that uses both but I kept the door open for the future if
 we wanted to have both in it for whatever reasons.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15816#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online