[tor-bugs] #13339 [Tor]: Merge GSoC project - Consensus Diffs

[Tor Bug Tracker & Wiki]

#13339: Merge GSoC project - Consensus Diffs
-------------------------+-------------------------------------------------
     Reporter:  mvdan    |      Owner:
         Type:           |     Status:  needs_revision
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  major    |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  gsoc, merge, tor-client, prop140,
   Resolution:           |  027-triaged-1-in
Actual Points:           |  Parent ID:
       Points:  medium   |
-------------------------+-------------------------------------------------

Comment (by nickm):

 Replying to [comment:21 mvdan]:
 > After a quick chat with Nick, what is left to do is clear to me:
 >
 [...]
 > > * I'd like to see fewer copies of strings done here. There's an easy
 way to do that, I think.
 >
 > nickm, what do you mean by 'here'?


 Let's forget about it for now and see if it matters in practice.

 > > * How expensive is dirserv_update_consensus_diffs? It seems kind of
 pricey. Maybe it needs to happen in the background?
 >
 > If we do that, we need some kind of mechanism to not serve any consensus
 diffs until they are all updated on disk and mmapped correctly. We need a
 thread-safe way to lock that out until it's complete. It could well get
 pricey, especially if the user sets a large SaveConsensuses value.

 Hm.  This is not a prerequisite for merging this patch then, but it will
 tell us how urgent it is to do another patch on top of it to background
 this computation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online