[tor-bugs] #15826 [Pluggable transport]: Check and return error values in goptlib

[Tor Bug Tracker & Wiki]

#15826: Check and return error values in goptlib
---------------------------------+---------------------
 Reporter:  gsathya              |          Owner:  asn
     Type:  defect               |         Status:  new
 Priority:  normal               |      Milestone:
Component:  Pluggable transport  |        Version:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
---------------------------------+---------------------
 Make goptlib check and return error values of functions, instead of
 silently ignoring them.

 {{{
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:557:15
 defer f.Close()
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:629:16
 io.WriteString(h, "ExtORPort authentication server-to-client hash")
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:630:9
 h.Write(clientNonce)
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:631:9
 h.Write(serverNonce)
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:638:16
 io.WriteString(h, "ExtORPort authentication client-to-server hash")
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:639:9
 h.Write(clientNonce)
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:640:9
 h.Write(serverNonce)
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:857:15
 s.SetDeadline(time.Now().Add(5 * time.Second))
 git.torproject.org/pluggable-transports/goptlib.git/pt.go:868:15
 s.SetDeadline(time.Time{})
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15826>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online