[tor-bugs] #15760 [Tor]: tortls.c fails to compile with OpenSSL 1.1.0-dev

[Tor Bug Tracker & Wiki]

#15760: tortls.c fails to compile with OpenSSL 1.1.0-dev
------------------------+------------------------------
     Reporter:  yancm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:  Tor: unspecified
    Component:  Tor     |    Version:  Tor: 0.2.7
   Resolution:          |   Keywords:  openssl, tor-tls
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------

Comment (by yawning):

 It occurs to me that this is dup-ish of #14188, except the reason for the
 breakage is that a whole bunch of stuff has been made totally opaque to
 application code.  I'm inclined to keep discussion here since it's a
 different issue.

 Ok, so I spent the time and looked into this a bit.  First the good news:

 {{{
 Apr 23 12:16:59.017 [notice] Tor v0.2.7.0-alpha-dev (git-ad9a71ed70d0f439)
 running on Linux with Libevent 2.0.22-stable, OpenSSL 1.1.0-dev and Zlib
 1.2.8.
 Apr 23 12:16:59.017 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Apr 23 12:16:59.017 [notice] This version is not a stable Tor release.
 Expect more bugs than usual.

 ...

 Apr 23 12:17:10.000 [notice] Bootstrapped 100%: Done
 }}}

 Now the bad news:
  * V2 link handshake support is totally broken and is not compiled at all
 (but, we're planning on killing it eventually anyway, so this may be ok
 one day, see #9476).  With enough persistence it may be possible to fix
 this, but I don't have more time to burn on this.
  * Reporting per-connection SSL buffer usage statistics is broken since
 the data structure is opaque (Oh well, not great but we can live with
 this).
  * `AUTHENTICATE` cell processing with the `RSA-SHA256-TLSSecret` AuthType
 is broken since it's not possible (at least easily) to get the TLS pre-
 master secret.  While this isn't used often in practice, this needs to be
 fixed somehow.

 Before I link my branch:

  * **DO NOT USE MY BRANCH** (Except as a starting point for fixing the
 stuff that I broke)
  * **DO NOT EXPECT THIS TO BE CORRECT, OR SAFE**
  * If people ignore the warnings, and it breaks in any way, shape, or
 form, resulting the men in suits coming for a visit and dragging them off
 in the van, I will point and laugh.

 My branch: https://github.com/Yawning/tor/compare/bug15760

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15760#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online