[tor-bugs] #15771 [Tor]: Reachability should check ExtendAllowPrivateAddresses not TestingTorNetwork

[Tor Bug Tracker & Wiki]

#15771: Reachability should check ExtendAllowPrivateAddresses not TestingTorNetwork
------------------------+--------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:  Tor: 0.2.6.1-alpha
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by teor):

 '''Branch:''' bug-15771-reachability
 '''Repository:''' ​https://github.com/teor2345/tor.git

 The code change is a simple substitution of ExtendAllowPrivateAddresses
 for TestingTorNetwork in the relevant location in circuitbuild.c, and re-
 wrapping to fit within line length limits.

 (The comment changes are larger than the code change.)

 The changes file is as follows:
       When self-testing reachability, use ExtendAllowPrivateAddresses
       to determine if local/private addresses imply reachability.
       The previous fix used TestingTorNetwork, which implies
       ExtendAllowPrivateAddresses, but this excluded rare configs where
       ExtendAllowPrivateAddresses is set but TestingTorNetwork is not.
       Fixes bug 15771; bugfix on 0.2.6.1-alpha, bug #13924.
       Patch by "teor", issue discovered by CJ Ess.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15771#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online