[tor-bugs] #9521 [Tor Browser]: "new identity" leaks memory in eventSuppressor.suppressEventHandling()

[Tor Bug Tracker & Wiki]

#9521: "new identity" leaks memory in eventSuppressor.suppressEventHandling()
-------------------------+-------------------------------------------------
     Reporter:  arma     |      Owner:  mikeperry
         Type:  defect   |     Status:  needs_information
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  tbb-newnym, interview, tbb-
   Resolution:           |  torbutton, ff38-esr
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by mikeperry):

 * keywords:  tbb-newnym, interview, tbb-torbutton => tbb-newnym, interview,
     tbb-torbutton, ff38-esr


Comment:

 I think we should revisit this in the ff38-esr timeframe. I am very
 nervous about Mozilla's belief that they completely fixed the underlying
 problem of being able to disable Javascript on a tab, and I'd like to
 review that code in-depth. However, it seems a little silly to dig through
 the ff31-esr code right now only to have some crucial detail change on us
 in ff38-esr.

 Unless of course there is a way to avoid the memory leak by removing the
 event suppressors in an unload handler or something similar while
 disposing of the associated tab. That might feel a little safer to me.
 Maybe. I still think I'd be wary of doing this in the 4.5 series though...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9521#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online