[tor-bugs] #15344 [Tor]: Integrate tests into automake test suite

[Tor Bug Tracker & Wiki]

#15344: Integrate tests into automake test suite
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  cypherpunks
  cypherpunks            |     Status:  needs_review
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:  Tor: 0.2.7
     Priority:  trivial  |   Keywords:  testing, 027-triaged-1-in, SponsorS
    Component:  Tor      |  Parent ID:
   Resolution:           |
Actual Points:           |
       Points:  small    |
-------------------------+-------------------------------------------------

Comment (by cypherpunks):

 Replying to [comment:8 nickm]:
 > I wonder if there's some way to do this without moving all our scripts
 into getting pre-processed by autoconf.
 I have not found a way to pipe output from one command to another without
 using wrapper scripts as in the ntor and backtrace tests. With regards to
 the zero length test, i agree it is ugly to have the entire script be
 processed by autoconf.

 A solution would be to give the path to the Tor binary as a parameter so
 it does not need to be hard coded into the script. As for the shell
 substitution (`@SHELL@`), it can be removed if the script does not need to
 call itself anymore. This be achieved by changing some logic within the
 script. These solutions would still require a wrapper script (similar to
 the ntor and backtrace tests) that calls the zero length script with the
 appropriate Tor binary but at least the zero length script itself would
 not require any pre-processing.

 As final remarks, i think we will always need some pre-processing in the
 tests if we want to support out-of-tree builds properly. The best solution
 i can currently come up with is to concentrate the pre-processing to the
 wrapper scripts.

 Expect a fixup patch in a couple of days.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15344#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online