[tor-bugs] #11879 [Tor Launcher]: 'Open Settings' button doesn't stop Tor from bootstrapping

[Tor Bug Tracker & Wiki]

#11879: 'Open Settings' button doesn't stop Tor from bootstrapping
-------------------------+-------------------------------------------------
     Reporter:  asn      |      Owner:  brade
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Launcher               |   Keywords:  tbb-4.5-alpha,
   Resolution:           |  TorBrowserTeam201504R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by mcs):

 * keywords:   => tbb-4.5-alpha, TorBrowserTeam201504R
 * status:  new => needs_review


Comment:

 Kathy and I tested this with TB 4.5 / Tor 0.2.6.x and did not see the
 problem that we observed with Tor 0.2.4.x (where bootstrapping failed to
 restart after DisableNetwork was set back to 0).  We did notice two
 smaller problems:

 a) Sometimes there is a delay (approximately 1 minute) before network
 activity continues.
 b) Depending on when you click "Open Settings" to stop the bootstrap, you
 may see a spurious error like:
   Tor failed to establish a Tor network connection.
   Loading network status failed (no route to host - xxx.xxx.xxx.xxx).

 With those caveats, it does seem like a nice improvement to interrupt the
 bootstrap process when the user clicks Open Settings or Cancel.  Here is a
 revised patch:
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug11879-02&id=81fd61c79e77e8dcbcfa42559a727ac384583f03

 Please review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11879#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online