[tor-bugs] #15642 [Tor]: Disable default fallback directories when DirAuthorities, AlternateDirAuthority, or FallbackDir are set

[Tor Bug Tracker & Wiki]

#15642: Disable default fallback directories when DirAuthorities,
AlternateDirAuthority, or FallbackDir are set
------------------------+----------------------------------
     Reporter:  teor    |      Owner:  teor
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:  Tor: 0.2.4.7-alpha
   Resolution:          |   Keywords:  tor-client tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------------------
Changes (by teor):

 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.7.x-final


Comment:

 I've created a new branch with unit tests for the new behaviour in
 `consider_adding_dir_servers` (all 10 valid cases):

 '''Branch:''' bug-15642-v2-fallback-unit-tests
 '''Repository:''' ​https://github.com/teor2345/tor.git
 '''Commits:'''
 * Fix to default fallback directories behaviour
 * Unit tests for `consider_adding_dir_servers` based on fixed default
 fallback directories behaviour. These are extensive because they cover
 each of 10 valid cases. There may be ways to abstract some of these shared
 code, but I feel it would make the tests less clear.

 Shifting this to 0.2.7 based on #13163's unit tests being in 0.2.7. Feel
 free to kick it out again.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15642#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online