[tor-bugs] #14429 [Tor Browser]: Automated rounding of content window dimensions

[Tor Bug Tracker & Wiki]

#14429: Automated rounding of content window dimensions
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting-resolution, tbb-
  Browser                |  torbutton
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 I think I have fixed most of the issues observed by Georg and Bernie.
 * I moved the quantizeBrowser(...) call to run after the resize_new_window
 stuff in torbutton.js, so that there is no mutual interference at all now.
 Formerly, interference was causing weird window sizes on startup and New
 Identity in linux.
 * A resize event was being accidentally dropped on linux, which probably
 resulted in the late zooming and expansion and inconsistent centering
 effects observed.
 * I sped up the shrinking to 0.5 sec on linux. Unfortunately, it's not
 possible to make the shrinking instantaneous because there is no signal
 available to Tor Browser (or Firefox) indicating when the user has stopped
 drag-resizing the window. It's possible that the user has only paused for
 0.5 sec, in which case attempting to shrink the window fails and a badly
 drawn window needs to be "rebuilt". We rebuild the window at the point
 when the user starts to use the browser (such as a mouseover or keypress).
 So a longer wait decreases the likelihood that we will need to rebuild the
 window, and a shorter wait is more appealing during normal use. Hopefully
 500 ms is a reasonable compromise.

 Here's the new patch:
 https://github.com/arthuredelstein/torbutton/commit/26660a0e87
 To try this out, you can download the torbutton XPI here:
 ​https://people.torproject.org/~arthuredelstein/downloads/torbutton-1.9.1.0-26660a0e87.xpi
 Signed by me:
 ​https://people.torproject.org/~arthuredelstein/downloads/torbutton-1.9.1.0-26660a0e87.xpi.asc
 The sha256sum of the XPI is:
 `54da4364d961195a470d059126071d4e98b6ab3dc22d12cf29da72c920b28a05`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14429#comment:73>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online