[tor-bugs] #13576 [Tor Launcher]: Tor Launcher strips "bridge" from the middle of bridge lines

[Tor Bug Tracker & Wiki]

#13576: Tor Launcher strips "bridge" from the middle of bridge lines
-------------------------+-------------------------------------------------
     Reporter:  dcf      |      Owner:  brade
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Launcher               |   Keywords:  tbb-usability,
   Resolution:           |  TorBrowserTeam201504, TorBrowserTeam201504R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by mcs):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:5 isis]:
 > Shown in the textbox? Or re-added to the beginning of the line? Because
 if the `"bridge "` prefix is being stripped once from the beginning of the
 line in parseAndValidateBridges(), and then not re-added again in
 setBridgeListElemValue():
 > ...
 > Then tor won't be able to set the "Bridge" config line.

 The lines contained in the textbox are not directly passed to the control
 port via SETCONF.

 TorSetConf() inside src/components/tl-protocol.js uses a JS object to
 construct a SETCONF command.

 For the bridge config., getAndValidateBridgeSettings() inside network-
 settings.js creates the JS object.  It contains two properties: "Bridge"
 (which is an array that contains the lines from the textbox) and
 "UseBridges" (which is a Boolean).  So the "Bridge" part really comes from
 the property name and does not depend on what is in the textbox (in the
 current code, parseAndValidateBridges() removes "bridge" everywhere within
 the text; this patch changes things to remove it on a line-by-line basis).

 Does the above make sense?

 > > 2. Lines within that textbox will not wrap, which means users may need
 to scroll horizontally to see long bridge lines (but Kathy and I think
 that is less confusing than wrapping).
 >
 > I agree. (I also added a similar change recently in BridgeDB because of
 the obfs4 lines being huge.)

 I am glad our approach matches yours.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13576#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online