[tor-bugs] #13576 [Tor Launcher]: Tor Launcher strips "bridge" from the middle of bridge lines

[Tor Bug Tracker & Wiki]

#13576: Tor Launcher strips "bridge" from the middle of bridge lines
-------------------------+-------------------------------------------------
     Reporter:  dcf      |      Owner:  brade
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Launcher               |   Keywords:  tbb-usability,
   Resolution:           |  TorBrowserTeam201504, TorBrowserTeam201504R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by isis):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 mcs]:
 > Thanks for the patch and sorry for the delay!  A fix that also includes
 some additional small improvements is available here:
 >
 > https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug13576-01&id=78f505c2139341e71538e77a975f7df9f81189d0
 >
 > Isis and Sherief -- Kathy and I value your opinion on these changes,
 especially:
 > 1. "bridge " will no longer be shown in Tor Launcher's custom bridges
 textbox.

 Shown in the textbox? Or re-added to the beginning of the line? Because if
 the `"bridge "` prefix is being stripped once from the beginning of the
 line in parseAndValidateBridges(), and then not re-added again in
 setBridgeListElemValue():

 {{{
 @@ -1406,11 +1407,7 @@ function setBridgeListElemValue(aBridgeArray)
      {
        var s = aBridgeArray[i].trim();
        if (s.length > 0)
 -      {
 -        if (s.toLowerCase().indexOf("bridge") != 0)
 -          s = "bridge " + s;
          bridgeList.push(s);
 -      }
      }
    }
 }}}

 Then tor won't be able to set the "Bridge" config line.

 > 2. Lines within that textbox will not wrap, which means users may need
 to scroll horizontally to see long bridge lines (but Kathy and I think
 that is less confusing than wrapping).

 I agree. (I also added a similar change recently in BridgeDB because of
 the obfs4 lines being huge.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13576#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online