[tor-bugs] #6411 [Tor]: Adding hidden services through control socket

[Tor Bug Tracker & Wiki]

#6411: Adding hidden services through control socket
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  yawning
  kevinevans             |     Status:  needs_revision
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:  Tor: 0.2.3.19-rc
     Priority:  normal   |   Keywords:  hidden-service control maybe-
    Component:  Tor      |  proposal tor-hs globalleaks-wants nickm-review
   Resolution:           |  Parent ID:  #8993
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by yawning):

 Quickly replying to stuff that doesn't require code changes, I'll fix the
 other things.

 Replying to [comment:55 nickm]:
 >  * What motivates the memwipe in crypto_pk_base64_encode() ?

 Because I'm doing "encode into newline delineated Base64, then strip out
 the newlines in place".  So the tail of the buffer will have some keying
 material past the nul terminator.  It's not a lot, of keying material,
 since it's Base64 encoded, and only the number of chars I'm stripping out,
 but better safe than sorry.

 >  * What happens if two control connections try to create an ephemeral
 hidden service with the same identity?  Is that case covered?

 Yes, I check for duplicates across all rend_services, on add, even ones
 from the torrc/setconf.  The only case that's not handled is duplicate
 identities across torrc HSes.

 >  * Is there a reason not to allow the GETINFO command to enumerate
 hidden services configured with the torrc file?

 I didn't want to complicate the patch further than what it already does
 (since it's rather large) by adding a way to iterate through
 rend_service_list.  It's something that can easily be added later as a
 separate patch, and in the mean time, GETCONF exists.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:56>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online