[tor-bugs] #6411 [Tor]: Adding hidden services through control socket

[Tor Bug Tracker & Wiki]

#6411: Adding hidden services through control socket
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  yawning
  kevinevans             |     Status:  needs_revision
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:  Tor: 0.2.3.19-rc
     Priority:  normal   |   Keywords:  hidden-service control maybe-
    Component:  Tor      |  proposal tor-hs globalleaks-wants nickm-review
   Resolution:           |  Parent ID:  #8993
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Notes:
  * <span class="darth-vader">I find your lack of
 tests....disturbing.</span>

  * What motivates the memwipe in crypto_pk_base64_encode() ?

  * Can we split the command-parsing part of add_onion handling into its
 own function, so that it can be tested separately?  It's pretty bulky...

  * Let's turn the return values from rend_service_add_ephemeral into an
 enum.

  * I'm not fond of naming variables l, because of I and 1.

  * The new return value for rend_add_service needs to get documented.

  * What happens if two control connections try to create an ephemeral
 hidden service with the same identity?  Is that case covered?

  * Is there a reason not to allow the GETINFO command to enumerate hidden
 services configured with the torrc file?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:55>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online