[tor-bugs] #14847 [Tor]: Controller: add a command to fetch HS descriptor from HSdir(s)

[Tor Bug Tracker & Wiki]

#14847: Controller: add a command to fetch HS descriptor from HSdir(s)
-------------------------+-------------------------------------------------
     Reporter:  dgoulet  |      Owner:  dgoulet
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  SponsorR tor-hs controller nickm-
   Resolution:           |  review
Actual Points:           |  Parent ID:  #3521
       Points:           |
-------------------------+-------------------------------------------------

Comment (by nickm):

 Quick code review:

 * This expression should maybe be extracted into a separate function:
 {{{
              strcmpstart(arg1, v2_str) == 0 &&
              strlen(arg1 + v2_str_len) == REND_DESC_ID_V2_LEN_BASE32 &&
              base32_decode(digest, sizeof(digest), arg1 + v2_str_len,
                            REND_DESC_ID_V2_LEN_BASE32) == 0)
 }}}

 * The name and documentation on rend_hsaddress_value() are a little vague.
 Maybe rend_hsaddress_str_or_unknown() ?

 * (Nick, Take a closer look at all the rendclient.c changes)

 * rend_cache_store_v2_desc_as_client() should set *entry to NULL on the
 no-reply case. (by convention)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14847#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online