[tor-bugs] #9969 [Tor]: We launch 50 microdesc requests, spread out over just three guards?

[Tor Bug Tracker & Wiki]

#9969: We launch 50 microdesc requests, spread out over just three guards?
------------------------+--------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by nickm):

 Replying to [comment:13 arlolra]:
 > > I think I should split it up into logical parts before we merge it.
 >
 > I can rebase and split up the patch if it's helpful.

 Up to you; I'd be happy to do it too.

 > > I like the changes in initiate_descriptor_downloads()... but I'm not
 so sure about "digest_len += 1". What "NULL" are we talking about?
 'digest' isn't NUL-terminated.
 >
 > The difference is that before you were building up one long string so
 when you base16_encode'd, you didn't want its NUL terminator. In the
 patch, we're making a smartlist of individual NUL terminated
 base16_encode'd strings, and then calling smartlist_join_strings on it,
 which will drop all the NULs.
 >
 > Hope that makes sense. It's been 6 months since I've looked at this, so
 still paging it back in.

 But digest_len is the length of the input, not the length of the output,
 right?  It gets used like this:
 {{{
 +      base16_encode(cp, enc_digest_len, smartlist_get(digests, lo),
 digest_len);
 }}}

 If anything, it's enc_digest_len that should get incremented by 1, I think

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9969#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online