[tor-bugs] #13163 [Tor]: Alternate{Dir, Bridge}Authority aren't sufficient for fully internal TestingTorNetwork (was: chutney: Alternate{Dir, Bridge}Authority aren't sufficient for fully internal TestingTorNetwork)

[Tor Bug Tracker & Wiki]

#13163: Alternate{Dir,Bridge}Authority aren't sufficient for fully internal
TestingTorNetwork
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:  Tor: unspecified
   Resolution:           |   Keywords:  tor-config tor-authority tor-test-
Actual Points:           |  network
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------
Changes (by teor):

 * keywords:  chutney tor-authority tor-test-network => tor-config tor-
     authority tor-test-network


Comment:

 So it's a tor bug:
 parse_dir_authority_line() treats a type of 0 as "any type", and documents
 this usage
 add_default_trusted_dir_authorities() treats a type of 0 as "any type",
 but is silent on this usage
 consider_adding_dir_servers() treats a type of 0 (NO_DIRINFO) as "no
 types", but calls add_default_trusted_dir_authorities(), which treats 0
 (NO_DIRINFO) as "any type". This is why the test network is escaping
 localhost.

 There are two alternative patches:
 1. I could patch the usage of NO_DIRINFO in consider_adding_dir_servers().
 2. I could make all functions respect NO_DIRINFO as NO_DIRINFO, and
 replace 0 with ALL_DIRINFO where that is what is meant. This is far more
 intrusive.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13163#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online