[tor-bugs] #13151 [Tor]: OR address is in host order in INTRODUCE2 cell

[Tor Bug Tracker & Wiki]

#13151: OR address is in host order in INTRODUCE2 cell
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  new
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-hs tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by arma):

 {{{
 diff --git a/src/or/rendservice.c b/src/or/rendservice.c
 index 31b612b..7d9978c 100644
 --- a/src/or/rendservice.c
 +++ b/src/or/rendservice.c
 @@ -1292,6 +1292,10 @@ rend_service_introduce(origin_circuit_t *circuit,
 const u
    if (!rp)
      goto log_error;

 +  log_notice(LD_REND, "Received intro2 cell, %s %s",
 +             fmt_addrport(&rp->addr, rp->port),
 +             hex_str(rp->identity_digest, DIGEST_LEN));
 +
    /* Check if we'd refuse to talk to this router */
    if (options->StrictNodes &&
        routerset_contains_extendinfo(options->ExcludeNodes, rp)) {
 }}}

 running on moria1 confirms the bug -- the addresses it's printing are in
 reverse order from the ones the relays advertise.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13151#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online