[tor-bugs] #13152 [Tor]: is_router_version_good_for_possible_guard() no longer needed

[Tor Bug Tracker & Wiki]

#13152: is_router_version_good_for_possible_guard() no longer needed
-------------------------+------------------------------------
 Reporter:  arma         |          Owner:
     Type:  enhancement  |         Status:  new
 Priority:  minor        |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor          |        Version:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
-------------------------+------------------------------------
 The function returns true for relays that are at least these versions:
 {{{
     /* CVE-2011-2769 was fixed on the relay side in Tor versions
      * 0.2.1.31, 0.2.2.34, and 0.2.3.6-alpha. */
     tor_assert(tor_version_parse("0.2.1.31",
                                  &first_good_0_2_1_guard_version)>=0);
     tor_assert(tor_version_parse("0.2.2.34",
                                  &first_good_0_2_2_guard_version)>=0);
     tor_assert(tor_version_parse("0.2.3.6-alpha",
                                  &first_good_later_guard_version)>=0);
 }}}

 yet all relays are at least those versions:
 {{{
   /* Versions before Tor 0.2.3.16-alpha are too old to support, and are
    * missing some important security fixes too. Disable them. */
   if (platform && !tor_version_as_new_as(platform,"0.2.3.16-alpha")) {
     if (msg)
       *msg = "Tor version is insecure or unsupported. Please upgrade!";
     return FP_REJECT;
   }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13152>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online