[tor-bugs] #13059 [Tor]: Create bad-relays file

[Tor Bug Tracker & Wiki]

#13059: Create bad-relays file
---------------------------+--------------------------------
     Reporter:  Sebastian  |      Owner:
         Type:  defect     |     Status:  needs_revision
     Priority:  normal     |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor        |    Version:
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:  #12898
       Points:             |
---------------------------+--------------------------------

Comment (by nickm):

 On
      {"AuthDirRejectCC", "AuthDirReject", 0, 0},

 Are the syntaxes the same?  Did AuthDirRejectCC take names wrapped in
 curly braces, the way that an authdirreject line will expect?  if not, the
 transition tool needs to add braces.

 Also:
   * I'd like the badrelays_t implementation stuff to be in its own file.
   * The function should be named badrelays_free(),  I think: not
 free_badrelays_set().
   * The return values from routerset_contains_router() should have
 constant names, and should be documented.  The code to convert them into
 strings should be its own function.
   * Why did you remove directory_remove_invalid() ?  We'll need to run
 that whenever we reload the badrelays file, right?
   * There should probably be some unit tests here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13059#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online