[tor-bugs] #13066 [Tor]: smartlist_choose_node_by_bandwidth() does not consider bad exit

[Tor Bug Tracker & Wiki]

#13066: smartlist_choose_node_by_bandwidth() does not consider bad exit
------------------------+------------------------------------
 Reporter:  asn         |          Owner:
     Type:  defect      |         Status:  new
 Priority:  minor       |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor         |        Version:
 Keywords:  tor-client  |  Actual Points:
Parent ID:              |         Points:
------------------------+------------------------------------
 `smartlist_choose_node_by_bandwidth()` does not check for the bad exit
 flag, and can return badexited relays. The sister function
 `smartlist_choose_node_by_bandwidth_weights` correctly checks for the bad
 exit flag.

 The good thing is that `node_sl_choose_by_bandwidth()` will only use the
 faulty function if the bandwidth weight system fails. This should not
 happen to the current network though. Hence, this does not seem to be a
 big issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13066>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online