[tor-bugs] #13064 [Tor]: TestingDirAuthVoteGuard doesn't work with nicknames

[Tor Bug Tracker & Wiki]

#13064: TestingDirAuthVoteGuard doesn't work with nicknames
--------------------+------------------------------------
 Reporter:  asn     |          Owner:
     Type:  defect  |         Status:  new
 Priority:  minor   |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor     |        Version:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 `TestingDirAuthVoteGuard` is examined before `rs->nickname` is populated
 in `set_routerstatus_from_routerinfo()`, so nickname routersets won't
 work.

 In my case, all relays in my testing network were marked as guards, but
 I'm not sure why.

 Moving the `TestingDirAuthVoteGuard` examination further down the function
 might fix the problem, but we should also maek sure that it supports all
 other routerset types.

 This is just a testing network issue btw.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13064>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online