[tor-bugs] #13049 [Tor Browser]: browser updater failure (self.update is undefined)

[Tor Bug Tracker & Wiki]

#13049: browser updater failure (self.update is undefined)
-----------------------------+--------------------
     Reporter:  mcs          |      Owner:  mcs
         Type:  defect       |     Status:  closed
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:  fixed        |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------
Changes (by mcs):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Here is the fix:

 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/9906e7e26e1dcbf313121dbf46e5a22aa185fd05

 Please merge this into the main repo.

 The problem with a 31.x update occurs for non-English bundles.  Since the
 language pack is an add-on and since it has maxVersion 24.* in its
 install.rdf, the updater code wants to check to ensure that a compatible
 update is available for the language pack before it starts downloading a
 browser update (if not, it will put up a prompt to warn the user about
 incompatible add-ons).  The same problem might occur with a third party
 add-on.

 So, in summary, the 4.0a2 updater fail in either of the following
 scenarios:

 1) English bundle with one or more extra add-ons installed that do not
 advertise compatibility with the platformVersion of the update.

 2) Non-English bundle while upgrading to a 31.x-based browser.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13049#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online