[tor-bugs] #3455 [Tor Browser]: Tor Browser should set SOCKS username for a request based on first party domain

[Tor Bug Tracker & Wiki]

#3455: Tor Browser should set SOCKS username for a request based  on first party
domain
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  mikeperry              |     Status:  needs_revision
         Type:           |  Milestone:  TorBrowserBundle 2.3.x-stable
  enhancement            |    Version:
     Priority:  major    |   Keywords:  tbb-linkability, tbb-usability,
    Component:  Tor      |  TorBrowserTeam201410, tbb-firefox-patch,
  Browser                |  MikePerry201410R, tbb-4.5-alpha
   Resolution:           |  Parent ID:  #5752
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Replying to [comment:67 gk]:
 > 3455.1 needs revision. The mingw-w64 compiler at least is not amused:
 > {{{
 > /home/ubuntu/build/tor-
 browser/netwerk/base/src/nsProtocolProxyService.cpp:1026:72: error:
 ambiguating new declaration of 'nsresult
 nsProtocolProxyService::DeprecatedBlockingResolve(nsIChannel*, uint32_t,
 nsIProxyInfo**)'
 >                                                    nsIProxyInfo
 **retval)
 >
 ^
 > }}}

 An here is the missing part:
 {{{
 In file included from /home/ubuntu/build/tor-
 browser/netwerk/base/src/nsProtocolProxyService.cpp:10:0:
 /home/ubuntu/build/tor-
 browser/netwerk/base/src/nsProtocolProxyService.h:50:14: note: old
 declaration 'nsresult
 nsProtocolProxyService::DeprecatedBlockingResolve(nsIChannel*, uint32_t,
 nsIProxyInfo**)'
      nsresult DeprecatedBlockingResolve(nsIChannel *aChannel,
               ^
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3455#comment:70>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online