[tor-bugs] #13594 [Tor Browser]: Tor Browser Bundle 4.0: updater fails on Windows

[Tor Bug Tracker & Wiki]

#13594: Tor Browser Bundle 4.0: updater fails on Windows
-----------------------------+----------------------
     Reporter:  marc         |      Owner:  tbb-team
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------

Comment (by gk):

 Replying to [comment:15 mcs]:
 > Replying to [comment:14 mcs]:
 > > I have not tested it yet, but would copying libssp-0.dll and
 msvcr100.dll into the updates\0 directory (next to the copy of
 updater.exe) fix this problem?
 >
 > Answering my own question... I did test this solution by manually
 copying the two needed DLLs into the updates\0 directory right before I
 clicked the "Restart To Update" button.  It worked.  The downside of this
 solution is that we would need to hard-code the names of those two DLLs
 into the browser, here:
 >
 > http://mxr.mozilla.org/mozilla-
 esr31/source/toolkit/xre/nsUpdateDriver.cpp#338
 >
 > which means that if, in the future, updater.exe depends on another DLL
 or if the name of one of the DLLs is changed, things will break again.

 Hmm... yes that is unfortunate, indeed.

 > I have not looked yet, but Mozilla must link their updater.exe in a
 special way to avoid external dependencies.  That might be the best
 solution, but it is probably more difficult to implement.

 That is tricky, yes, as we e.g. for XP users link against msvcr100 and our
 hardening plays a role here, too. If I understand comment:9 and comment:12
 correctly then that might be a good solution we could try.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13594#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online