[tor-bugs] #13577 [Tor]: Fix clang compilation warnings in tor, trunnel

[Tor Bug Tracker & Wiki]

#13577: Fix clang compilation warnings in tor, trunnel
------------------------+------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:
    Component:  Tor     |    Version:  Tor: unspecified
   Resolution:          |   Keywords:  clang
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------

Comment (by teor):

 Yes, !! is pretty ugly, isn't it?

 I think -Wno-parenthesis-equality is the best option, as it's obviously
 not adding that much value if it's causing these sorts of false positives.
 But I'm concerned that it is actually adding value in some cases (i.e. =
 vs == in conditionals)

 I also have doubts about moving the !! into the macro, because !! would
 have to sit outside the macro's outer brackets to be effective. And that
 causes its own issues.

 We could use inline functions, but that might break some of the
 consistency / encapsulation / optimisation. I'll look into it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13577#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online