[tor-bugs] #3455 [Tor Browser]: Tor Browser should set SOCKS username for a request based on first party domain

[Tor Bug Tracker & Wiki]

#3455: Tor Browser should set SOCKS username for a request based  on first party
domain
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  mikeperry              |     Status:  needs_review
         Type:           |  Milestone:  TorBrowserBundle 2.3.x-stable
  enhancement            |    Version:
     Priority:  major    |   Keywords:  tbb-linkability, tbb-usability,
    Component:  Tor      |  TorBrowserTeam201410, tbb-firefox-patch,
  Browser                |  MikePerry201410R, tbb-4.5-alpha
   Resolution:           |  Parent ID:  #5752
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mikeperry):

 After a quick look at the Torbutton side of the code -- I am wondering
 what happens with favicons. Historically, Mozilla's filters often miss
 those. I am also wondering how this interacts with requests from the
 addons pane. Neither of these are blockers, but we should be aware of
 these issues if they exist.

 I am also a little concerned with your initialization.
 DomainIsolator.observe() is actually going to be called for several
 different observer topics. It may be causing multiple proxy filters to get
 registered. You should probably be checking for topic == "profile-after-
 change".

 I still need to review the C++ side.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3455#comment:63>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online