[tor-bugs] #8641 [TorBrowserButton]: Create Browser UI indication for current circuit status and exit IP

[Tor Bug Tracker & Wiki]

#8641: Create Browser UI indication for current circuit status and exit IP
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  mikeperry              |     Status:  needs_information
         Type:           |  Milestone:
  enhancement            |    Version:
     Priority:  major    |   Keywords:  tbb-usability,
    Component:           |  TorBrowserTeam201410D
  TorBrowserButton       |  Parent ID:  #5752
   Resolution:           |
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:37 mikeperry]:
 > I am not sure that the "first stream on a new circuit is a url bar load"
 assumption is a good one.

 I have upgraded the patch to make this assumption unnecessary. Instead,
 this new version relies on a patch to Tor at
 https://trac.torproject.org/projects/tor/attachment/ticket/8405/0001-Bug-8405
 -Report-SOCKS-username-password-in-CIRC-stat.patch in which SOCKS_USERNAME
 and SOCKS_PASSWORD are reported via the ControlPort for each CIRC event.
 STREAM events are no longer monitored.

 (This patch also requires that the 3 patches from #3455 have been
 applied.)

 > We may want to use a combination of
 https://developer.mozilla.org/en/nsIWebProgressListener and some tab
 switching events for this UI.

 In this patch, the `syncDisplayWithSelectedTab` function uses (1)
 [https://developer.mozilla.org/en-
 US/docs/Mozilla/Tech/XUL/Method/AddTabsProgressListener
 `gBrowser.addTabsProgressListener`] which is very similar to using an
 nsIWebProgressListener, and (2)
 gBrowser.tabContainer.addEventListener("[https://developer.mozilla.org/en-
 US/docs/Web/Events/TabSelect TabSelect]", ...) which listens for tab
 switching events.

 > HTTPS-Everywhere's "ApplicableList" code, as well as NoScript's UI
 plumbing are probably useful places to look to ensure that this UI gets
 cleared/updated properly on new URL bar loads and tab changes.

 In my testing so far, this patch seems to be correctly updating or
 clearing whenever a tab is selected or a new page loads. But I may be
 overlooking something.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8641#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online