[tor-bugs] #13362 [Onionoo]: Make Onionoo's logs more useful

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Oct 8 07:35:01 UTC 2014


#13362: Make Onionoo's logs more useful
-----------------------------+--------------------------
     Reporter:  karsten      |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by iwakeh):

 Thanks, for removing the parenthesis bug from FILEERR.

 All the formatting and other choices I made, when writing the logback.xml,
 were
 suggestions and examples (like the runtime value), b/c I could not really
 infer what is necessary or wanted and I intended to showcase some of the
 features of logback.
 I should have pointed it out more clearly, when the logging was
 introduced.
 So, good that we now get around to defining the logging structure in
 detail!

 Logging should be separated from the application (as far as possible).
 Thus, we should avoid changes like this
 {{{
 -            su.getClass().getSimpleName(), statsString);
 +            su.getClass().getSimpleName() + "\n" + statsString);
 }}}
 The same result can be achieved by changing the pattern in logback.xml to
 {{{<pattern>${utc-date-pattern} %logger{0} %msg%n</pattern>}}}

 Another topic for the logging documentation we talked about in the e-mail-
 appender issue.
 Maybe, add one document about configuration, which will contain the
 logging decisions/findings
 discussed so far and later some configuration topics for the embedded
 jetty?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13362#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list