[tor-bugs] #12716 [meek]: Make meek-client-torbrower take the firefox command as a parameter

[Tor Bug Tracker & Wiki]

#12716: Make meek-client-torbrower take the firefox command as a parameter
------------------------+-----------------
     Reporter:  dcf     |      Owner:  dcf
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:
    Component:  meek    |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-----------------

Comment (by infinity0):

 How about the following:

 {{{
 meek-client-helper /path/to/meek/client <meek-client args> -- <helper
 command line>
 }}}

 We know meek-client doesn't use --, so this is safe in all cases. Then,
 meek-client-helper doesn't need any args of its own.

 To make things work on OSX, we do this in the Bridge line (until that
 Mozilla bug is fixed):

 {{{
 meek-client-helper <etc> -- sh -c '"$1" -no-remote -profile "$(realpath
 "$2")"' TBB ./rel/path/to/firefox ./rel/path/to/profile
 }}}

 "TBB" can be anything, it's just what would show up in process lists as
 the "command name".

 This means we can remove all firefox/tbb specificness from this program,
 as well as the OSX workaround. I am ''hoping'' the Bridge line supports
 args with spaces in. If it doesn't, we can instead write a wrapper shell
 script that calls firefox and does $(realpath) on the profile arg.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online