[tor-bugs] #13788 [Tor Browser]: Meek bridges don't work in TB 4.5alpha1

[Tor Bug Tracker & Wiki]

#13788: Meek bridges don't work in TB 4.5alpha1
-----------------------------+----------------------
     Reporter:  cypherpunks  |      Owner:  tbb-team
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  meek
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------
Changes (by gk):

 * cc: arthuredelstein (added)


Comment:

 The offending patch is: https://gitweb.torproject.org/tor-
 browser.git/commitdiff/e0eaf6b471ae3bbc06066232a00f3b27c2bedeee

 And I think I know what is going on: `nsSocketTransport::SocketHost()` is
 using the host of the nsIProxyInfo if there is any. And per default meek
 is creating an HTTP channel with a nsIProxyInfo which is instructing the
 browser to make a direct connection (type `DIRECT`). Thus, the host is
 empty but is nevertheless selected as the socket host as
 {{{
 if (mProxyInfo && !mProxyTransparent) {
 }}}
 is `true`. I guess we should just check that we not only have an
 nsIProxyInfo but a non-empty host as well
 (`nsSocketTransport::SocketPort()` is affected, too). Arthur?

 (dcf - thanks for the logs they were pretty helpful and saved me some time
 :) )

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13788#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online