[tor-bugs] #13818 [Tor Browser]: [PATCH] Active tab looks ugly (inherits system color scheme only partially)

[Tor Bug Tracker & Wiki]

#13818: [PATCH] Active tab looks ugly (inherits system color scheme only partially)
-----------------------------+-----------------------------------
     Reporter:  gentoo_root  |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201411R
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------

Comment (by gentoo_root):

 >It will only be set to true if IsBeingUsedAsImage() returns true... which
 sounds like it would be true in the case where you load the SVG as a top-
 level document.

 I've just attached a patch (that applies on top of my first patch) to test
 IsChromeOriginImage. When I load chrome://browser/skin/tabbrowser/tab-
 selected-start.svg in browser, I see that lines on my console (repeating
 multiple times):

 aPresContext->IsChromeOriginImage() == 0
 URI: scheme="chrome"; host="browser"; path="/skin/tabbrowser/tab-selected-
 start.svg"

 And when I load test.html, I see something like that:

 aPresContext->IsChromeOriginImage() == 0
 URI: scheme="file"; host=""; path="/tmp/.private/max/test.html"
 aPresContext->IsChromeOriginImage() == 1
 URI: scheme="chrome"; host="browser"; path="/skin/tabbrowser/tab-selected-
 start.svg"

 So IsChromeOriginImage() == false when I load SVG as a top-level document,
 and true when I embed SVG into HTML page.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13818#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online